22 Pro
2013
22 Pro
'13
23:27
On 22/12/2013 23:06, Marek Vavruša wrote:
Hi Marek,
Thanks for the patch, but it fails to apply against 1.4.0-rc2. I get:
$ patch -p1 < ../../axfr_retry_cutoff.patch
patching file src/knot/server/xfr-handler.c
Hunk #1 FAILED at 321.
1 out of 1 hunk FAILED -- saving rejects to file
src/knot/server/xfr-handler.c.rej
patching file src/knot/server/zones.h
Hunk #1 FAILED at 43.
1 out of 1 hunk FAILED -- saving rejects to file src/knot/server/zones.h.rej
it is progressive at the moment, but it probably
doesn't suit well for
this issue.
The progression is set to random 0-30s increments up to 10 minutes maximum.
The question is now what is sane, I'd like to avoid another configurable here.
To start the ball rolling, the attached patch tweaks the settings to
double the previous interval plus jitter (30s).
I think it is a good compromise that allows relatively fast few tries
(about 3 in a few subsequent minutes) and spins
into hours in about 7 tries. Interval cap is set at the 24 hours, it
seems reasonable as the zone can be always refreshed using knotc. The
cut-off could be a bit more aggressive probably, that's the open
question.